Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReadMe Instructions Mistake in Go Version Determination #31

Open
emendir opened this issue Aug 6, 2023 · 1 comment
Open

ReadMe Instructions Mistake in Go Version Determination #31

emendir opened this issue Aug 6, 2023 · 1 comment
Labels
effort/hours Estimated to take one or several hours kind/bug A bug in existing code (including security flaws) P2 Medium: Good to have, but can wait until someone steps up topic/docs Documentation

Comments

@emendir
Copy link

emendir commented Aug 6, 2023

First of all, thanks for the work on making this example plugin usable again!

There is an issue, however, in the instructions in the ReadMe, where it says:

You need to be using the same Go version to compile Kubo and the plugin. Upstream releases of Kubo use whatever it says here (v0.19.10) at the time of writing.

The provided URL doesn't always provide the correct version. On the 6th of August 2023 I tried following the instructions with the latest version of kubo (0.21.0). At that time the link in the instructions https://github.com/ipfs/distributions/blob/master/.tool-versions#L2 said golang 1.19.11, which resulted in errors when running the plugin. When running kubo in the terminal with ipfs daemon, I noticed in the console output it said Golang version: go1.19.10, so I reinstalled go with that version and then the plugin worked.

@emendir emendir added the need/triage Needs initial labeling and prioritization label Aug 6, 2023
@hsanjuan
Copy link
Contributor

hsanjuan commented Aug 8, 2023

Yes, much better to use ipfs version --all to check that, which includes the Go version. Mind PRing this?

@aschmahmann aschmahmann added topic/docs Documentation kind/bug A bug in existing code (including security flaws) P2 Medium: Good to have, but can wait until someone steps up effort/hours Estimated to take one or several hours and removed need/triage Needs initial labeling and prioritization labels Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort/hours Estimated to take one or several hours kind/bug A bug in existing code (including security flaws) P2 Medium: Good to have, but can wait until someone steps up topic/docs Documentation
Projects
None yet
Development

No branches or pull requests

3 participants