Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go-ipld-prime@v0.5.0 #92

Merged
merged 3 commits into from
Sep 23, 2020
Merged

Update go-ipld-prime@v0.5.0 #92

merged 3 commits into from
Sep 23, 2020

Conversation

warpfork
Copy link
Member

@warpfork warpfork commented Sep 8, 2020

Simultaneously updates go-ipld-prime-proto, which also has changes to match that version of go-ipld-prime.

@welcome
Copy link

welcome bot commented Sep 8, 2020

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

@@ -196,7 +196,7 @@ type BlockData interface {
type IncomingRequestHookActions interface {
SendExtensionData(ExtensionData)
UsePersistenceOption(name string)
UseLinkTargetNodeStyleChooser(traversal.LinkTargetNodeStyleChooser)
UseLinkTargetNodePrototypeChooser(traversal.LinkTargetNodePrototypeChooser)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that there's a small change to the exported interface of this library. I applied the rename of s/NodeStyle/NodePrototype/ universally, for consistency.

There's no behavioral change, so any yet-further-downstream consumers should be able to literally apply that regexp when updating and be fine.

warpfork and others added 3 commits September 22, 2020 15:27
Simultaneously updates go-ipld-prime-proto, which also has changes to
match that version of go-ipld-prime.
update to lastest needed sha for filecoin, reinstitute generated node tests
@hannahhoward hannahhoward merged commit a0cc6f0 into master Sep 23, 2020
@aschmahmann aschmahmann mentioned this pull request Feb 18, 2021
73 tasks
@mvdan mvdan deleted the updates branch December 15, 2021 14:16
marten-seemann pushed a commit that referenced this pull request Mar 2, 2023
* Emit events with received cids (#71)

* persist received cids on channel state.

* Send, Receive and Validate Restart requests (#75)

* Send, Receive and Validate Requests

* Initiating and Responding Tests and bug fixes (#76)

* Testing for resuming data transfer work

* Cleanup Push Restarts PR  (#79)

* cleanup of restart PR

* link the peers

* Tests for pull restarts (#84)

* tests for pull restarts

* Merge Tests cleanup work (#92)

* cleanup of restart PR

* cleanup timedout channels (#93)

* backward compatibility of restart (#96)

* backward compatibility of restart

* changes and tests

* more tests

* better error handling for restarts

* feat(message): switch to cbor map encoding (#97)

switch to cbor map encoding for the 1_1 message protocol

* feat(channels): setup datastore migrations (#99)

setup datatransfer channels so they migrate over successfully

Co-authored-by: Hannah Howard <hannah@hannahhoward.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants