Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add license file so it can be found by go-licenses #27

Merged
merged 1 commit into from
Feb 11, 2021

Conversation

bollwyvl
Copy link
Contributor

Thanks for this! I'm trying to package go-ipfs for conda-forge, and this is one of the few modules that doesn't have a discoverable license file.

@welcome
Copy link

welcome bot commented Feb 11, 2021

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

@willscott willscott merged commit 74e39ea into ipfs:master Feb 11, 2021
@willscott
Copy link
Contributor

@bollwyvl Unclear if everything will be in place for the 0.8.0 release to use tagged releases of all packages in a way that works with your go-license check

@bollwyvl bollwyvl deleted the patch-1 branch February 11, 2021 05:30
@bollwyvl
Copy link
Contributor Author

Thanks for the super-fast response!

Don't worry about me! I'm just trying to get something built (0.7.0), with at least minimum due diligence. This license was already documented, and MIT doesn't require it being distributed, so everybody was already doing everything right!

Now that there is something to point at, I can reference that when packaging. I don't really know how go-licenses works under the hood, but hopefully, after the build, I'll just scrub the offending vendor folders, and manually append the missing licenses to the Big Old Generated Third Party License File... unless somehow the --ignore flag gets merged first (has been sitting for a few months).

Either way, thanks again, and best of luck on 0.8.0 🚀 !

@aschmahmann
Copy link

aschmahmann commented Feb 11, 2021

@bollwyvl I saw you filed a bunch of PRs doing this. I think using https://github.com/ipfs/ipfs-repository-template/blob/master/LICENSE.md would be better than just MIT (that file is for the dual Apache-2.0/MIT licensing like what go-ipfs has).

@bollwyvl
Copy link
Contributor Author

Cool... for the most part, I'm just reacting to what i see in these repos, presumably at the hashes that are baked into 0.7.0... at least this way there's a record of the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants