Skip to content
This repository has been archived by the owner on Feb 1, 2023. It is now read-only.

Don't decrease split on unique message #120

Open
Stebalien opened this issue May 10, 2019 · 1 comment
Open

Don't decrease split on unique message #120

Stebalien opened this issue May 10, 2019 · 1 comment
Assignees
@hannahhoward

Comments

@Stebalien
Copy link
Member

Stebalien commented May 10, 2019 •
edited
Loading

We should decrease the split when we fail to receive a message. Otherwise, we'll get a minimum of 50% duplicate blocks if everyone has every block.
@Stebalien
Copy link
Member Author

As far as I can tell, not receiving a message causes us to broadcast the request, receive a bunch of duplicate blocks, and then increase the split. This seems backwards.

@hannahhoward hannahhoward mentioned this issue Jul 30, 2019
Open
8 tasks
@Stebalien Stebalien mentioned this issue Aug 21, 2019
Open
This was referenced Jan 27, 2023
Open
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hannahhoward hannahhoward

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Stebalien @hannahhoward