Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build directly with go mod #240

Closed
Stebalien opened this issue Jun 5, 2019 · 1 comment
Closed

Build directly with go mod #240

Stebalien opened this issue Jun 5, 2019 · 1 comment

Comments

@Stebalien
Copy link
Member

Stebalien commented Jun 5, 2019 •
edited
Loading

We currently resolve dependencies with go mod but we still don't build the main package with go mod (e.g., go get github.com/ipfs/go-ipfs/cmd/ipfs@version). Unfortunately, this means go plugins can't reliably be built against our dists. See: ipfs/go-ds-s3#17.

Unfortunately, we still need to clone the repo as go mod throws away permissions.
@Stebalien Stebalien mentioned this issue Jun 6, 2019
Merged
@Stebalien
Copy link
Member Author

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Stebalien