From 98d4664b0fe892ff0322d97a6d6b1ca38b54950d Mon Sep 17 00:00:00 2001 From: Richard Littauer Date: Mon, 2 Nov 2015 05:06:34 -0500 Subject: [PATCH] Small edits Added note about emailing Juan This was in the main ipfs/ipfs repo, and belonged here too. I also removed a couple of blank lines. See https://github.com/ipfs/community/issues/63 for more. --- contributing.md | 7 +++++-- contribution-guidelines.md | 4 ++-- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/contributing.md b/contributing.md index ff2456e1..ceb17a31 100644 --- a/contributing.md +++ b/contributing.md @@ -22,6 +22,7 @@ helping us improve our community. * [Contribution Guidelines](#contribution-guidelines) * [Community Guidelines](#community-guidelines) * [Community Improvement](#community-improvement) +* [Helping in other ways](#helping-in-other-ways) ### Security Issues @@ -48,7 +49,6 @@ uname -a >>/tmp/ipfs-bug-report It may also be relevant to look at the eventlog of your ipfs node, but we will request it if so. - ### Protocol Design When considering protocol design proposals, we are looking for: @@ -69,7 +69,6 @@ When considering design proposals for implementations, we are looking for: - Discussion of the tradeoffs involved - Discussion of the proposed solution - ### Contribution Guidelines Please see [contribution-guidelines.md](contribution-guidelines.md). @@ -91,3 +90,7 @@ There is also a more extensive [code-of-conduct](code-of-conduct.md). ### Community Improvement The IPFS community requires maintenance of various "public infrastructure" resources. These include documentation, github repositories, CI build bots, and more. There is also helping new users with questions, spreading theword about IPFS, and so on. Soon, we will be planning and running conferences. Please get in touch if you would like to help out. + +### Helping in other ways + +Protocol Labs occasionally is able to hire developers for part time or full time positions, to work on IPFS. If you are interested, check out [the job listings](http://ipn.io/join/#pm). If you'd like to help in other ways, [email @jbenet directly](mailto:juan@ipfs.io?subject=Contributing to IPFS). diff --git a/contribution-guidelines.md b/contribution-guidelines.md index 2e52f31c..e3b36585 100644 --- a/contribution-guidelines.md +++ b/contribution-guidelines.md @@ -124,9 +124,9 @@ Write clean code. Universally formatted code promotes ease of writing, reading, ### Tests -Submit tests with your changes. Take a look at existing tests for inspiration. Run the full test suite on your branch before submitting a pull request. +If the repository you are working on has a testing suite, submit tests with your changes. Take a look at existing tests for inspiration. Run the full test suite on your branch before submitting a pull request. -For commandline tool changes, please write appropriate sharness tests. +For command line tool changes, please write appropriate sharness tests. ### Documentation