Skip to content
This repository has been archived by the owner on Apr 29, 2020. It is now read-only.

Add code coverage #90

Open
RichardLitt opened this issue Aug 11, 2016 · 13 comments
Open

Add code coverage #90

RichardLitt opened this issue Aug 11, 2016 · 13 comments
Milestone

Comments

@RichardLitt
Copy link
Collaborator

See ipfs/kubo#3053 (comment).

@harlantwood
Copy link
Collaborator

+1

@RichardLitt RichardLitt modified the milestone: Q4 features Nov 18, 2016
@Kubuxu
Copy link

Kubuxu commented Dec 15, 2016

We use currently two coverage report providers, coveralls and codecov. Many of our current repos (especialy js) use coveralls but codecov has superior UX and UI, transition would be trival.

@RichardLitt
Copy link
Collaborator Author

@Kubuxu Cool. What should I add? The badge?

@Kubuxu
Copy link

Kubuxu commented Dec 15, 2016

I think it badge which links to the project's page would be ok.

@RichardLitt
Copy link
Collaborator Author

Cool. And that is for all go-* and js-* repos, right?

@Kubuxu
Copy link

Kubuxu commented Dec 16, 2016

Not all of them have coverage reports yet but yes.

@RichardLitt
Copy link
Collaborator Author

Ok. Can you point to one example of the badge? I'm not seeing it on go-ipfs; is it being used elsewhere atm?

@RichardLitt
Copy link
Collaborator Author

Or is this it:

[![Coverage Status](https://coveralls.io/repos/github/ipfs/go-ipld-node/badge.svg?branch=master)](https://coveralls.io/github/ipfs/go-ipld-node?branch=master)
[![Codecov](https://img.shields.io/codecov/c/github/codecov/example-python.svg)]()

I'll add the second (codecov) and open an issue about switching; that work for you? Where should I point questions about that - I don't see an issue in ipfs/community about the switch. Where is that discussion happening?

@Kubuxu
Copy link

Kubuxu commented Dec 16, 2016

There was no discussion yet, I will start issue in community.

@Kubuxu
Copy link

Kubuxu commented Dec 19, 2016

I like this style of badges a lot:

We could use the same style of icons from shields.io for Travis, Circle and the normal task:

@RichardLitt
Copy link
Collaborator Author

In that case, I will start looking for or adding:

![CodeCov](https://img.shields.io/codecov/c/github/ipfs/go-ipfs.svg?style=flat-square)
[![Travis CI](https://travis-ci.org/ipfs/go-ipld-node.svg?branch=master)](https://img.shields.io/travis/ipfs/go-ipld-node.svg)

CodeCov
Travis CI

To every IPFS repo.

@Kubuxu
Copy link

Kubuxu commented Dec 26, 2016

We should probably make the coverage shield clickable.

@RichardLitt
Copy link
Collaborator Author

[![codecov.io](https://img.shields.io/codecov/c/github/ipfs/go-ipfs.svg?style=flat-square&branch=master)](https://codecov.io/github/ipfs/go-ipfs?branch=master)
[![Travis CI](https://img.shields.io/travis/ipfs/go-ipld-node.svg?branch=master&style=flat-square)](https://travis-ci.org/ipfs/go-ipld-node/)

codecov.io
Travis CI

Look better?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants