Skip to content
This repository has been archived by the owner on Apr 29, 2020. It is now read-only.

Rabin tests fail on current master #5

Closed
vmx opened this issue Dec 17, 2018 · 2 comments
Closed

Rabin tests fail on current master #5

vmx opened this issue Dec 17, 2018 · 2 comments

Comments

@vmx
Copy link
Contributor

vmx commented Dec 17, 2018

The rabin module doesn't compile successfully on Linux. The problem is in the nan module.

Steps to reproduce:

npm install
npx mocha --timeout 5000 --ui bdd --colors --exit test/node.js --grep rabin

The tests will pass after installing an older version of nan:

npm install --save-optional nan@2.11.0
@vmx
Copy link
Contributor Author

vmx commented Dec 17, 2018

Upstream bug is: nodejs/nan#832.

@vmx
Copy link
Contributor Author

vmx commented Dec 19, 2018

The upstream bug got fixed and if i do a fresh install locally, tests pass.

@vmx vmx closed this as completed Dec 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant