Skip to content
This repository has been archived by the owner on Oct 16, 2020. It is now read-only.

Use an api call from the whitelist to check if the http api is available #4

Closed
olizilla opened this issue Aug 21, 2018 · 2 comments
Closed

Comments

@olizilla
Copy link
Collaborator

We're using a call to.id() to verify that the ipfs instance is working. That triggers an confirmation modal when using window.ipfs. We don't want to trigger that if the app doesn't need the id of the current node. This should be swapped to a call that is on the whitelist: https://github.com/ipfs-shipyard/ipfs-companion/blob/master/add-on/src/lib/ipfs-proxy/acl-whitelist.json

@olizilla
Copy link
Collaborator Author

This should also be something from the read-only / gateway api as per https://github.com/ipfs/go-ipfs/blob/727bf49eff7ff61936aee6d4674ae3e7ad0aaddb/core/commands/root.go#L155-L187

@olizilla
Copy link
Collaborator Author

olizilla commented Oct 4, 2018

Fixed in #15

@olizilla olizilla closed this as completed Oct 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant