Support printing entire structs #2557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viktormalik
force-pushed
the
struct-print
branch
from
0ba4d3e to
da62e18
Compare
3 tasks
ajor
approved these changes
Apr 6, 2023
Pointers are printed in hex format, e.g. "0xdeadbeef". This is especially useful when printing structs containing pointer fields. This changed the output format of some regression tests so they are updated accordingly.
Until now, field analyser resolved struct fields for structs accessed via a pointer only when the pointer dereference was followed by a field access, i.e. for cases like `p->field`. This does the field resolution on every dereference, particularly allowing to print the entire struct using `print(*p)`. Includes a test case for kfunc which failed before this change.
viktormalik
force-pushed
the
struct-print
branch
from
da62e18 to
82d54a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now, field analyser resolved struct fields for structs accessed via a pointer only when the pointer dereference was followed by a field access, i.e. for cases like
p->field.This does the field resolution on every dereference, particularly allowing to print the entire struct using
print(*p).Also improves printing of pointers as they are often members of kernel structs.
Checklist
man/adoc/bpftrace.adocand if needed indocs/reference_guide.mdCHANGELOG.md