Make kaddr() report failure for unknown kernel symbols #1836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, bad kaddr() calls would silently fail and return 0. This is bad b/c you silently get bad data. Let's report and error and fail instead.
fbs
approved these changes
May 10, 2021
fbs
reviewed
May 10, 2021
| @@ -612,6 +612,8 @@ void CodegenLLVM::visit(Call &call) | |||
| uint64_t addr; | |||
| auto name = bpftrace_.get_string_literal(call.vargs->at(0)); | |||
| addr = bpftrace_.resolve_kname(name); | |||
| if (!addr) | |||
| throw std::runtime_error("Failed to resolve kernel symbol: " + name); | |||
There was a problem hiding this comment.
Not sure about that. codegen isn't hooked up to check for error messages like semantic_analyser is. Could LOG(FATAL) but it'd be better if we had a nice message instead
There was a problem hiding this comment.
Unless you mean we should in the future. In which case my suggestion would be that this shouldn't happen in codegen anyways. I'll probably clean this up as part of my AOT project
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, bad kaddr() calls would silently fail and return 0. This is
bad b/c you silently get bad data. Let's report and error and fail
instead.
Checklist
docs/reference_guide.mdCHANGELOG.md