Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix single arg wildcard probe listings #1775

Merged
merged 3 commits into from
Apr 7, 2021

Conversation

danobi
Copy link
Member

@danobi danobi commented Apr 6, 2021

We regressed on single arg wildcard probe listings. eg.

# bpftrace -l '*sleep*'

We should support this b/c the docs have said we support this.
Even bpftrace --help shows the above example.

This fixes #1773.

Checklist
  • Language changes are updated in docs/reference_guide.md
  • User-visible and non-trivial changes updated in CHANGELOG.md
  • The new behaviour is covered by tests

@danobi
Copy link
Member Author

danobi commented Apr 6, 2021

cc @viktormalik

@danobi danobi force-pushed the single_arg_wildcard_list branch from 4296fb6 to 7d79cc5 Compare April 6, 2021 17:54
danobi added 3 commits April 6, 2021 10:58
The docs say we can do stuff like

  # bpftrace -l "*sleep*"

so we should probably implement it. We probably regressed on this during
the probe matching refactoring.
@danobi danobi force-pushed the single_arg_wildcard_list branch from 7d79cc5 to 37ff158 Compare April 6, 2021 18:48
@danobi danobi merged commit 2c7a7a5 into bpftrace:master Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Probe listing not working as expected
2 participants