ustd: better handling of empty namespaces #1486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an empty namespace is given, it is deduced automatically. We assume that a single probe with the given name exists. If multiple probes having the same name but different namespaces are matched, no probes are attached to and the user is told to use an explicit wildcard for the namespace. Specifying a wildcard in the probe name will allow multiple probes to be matched even if the namespace is empty. This solves dicrepancy between the tests (which treat an empty namespace as a wildcard) and the reference guide (which says that an empty namespace is replaced by the binary name). The tests and the reference guide are updated accordingly to the new behavior.
viktormalik
force-pushed
the
usdt-ns-fix
branch
from
31bf660
to
497f526
Compare
|
nice |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an empty namespace is given, it is deduced automatically. We assume that a single probe with the given name exists. If multiple probes having the same name but different namespaces are matched, no probes are attached to and the user is told to use an explicit wildcard for the namespace.
This solves dicrepancy between the tests (which treat an empty namespace as a wildcard) and the reference guide (which says that an empty namespace is replaced by the binary name).
Resolves #1469 and fixes #1466.
Checklist
docs/reference_guide.mdCHANGELOG.md