Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List retprobes #1484

Merged
merged 1 commit into from
Aug 26, 2020
Merged

List retprobes #1484

merged 1 commit into from
Aug 26, 2020

Conversation

mmisono
Copy link
Collaborator

@mmisono mmisono commented Aug 25, 2020

bpftrace -l does not show retprobes (uretprobe, kretprobe, kretfunc)
even if a search keyword is given (e.g., bpftrace -l 'kr:vfs_open'), and
this may confuse users. List retprobes if a user searches them.

Example:

% sudo ./src/bpftrace -l 'kr:vfs*'
kretprobe:vfs_fadvise
kretprobe:vfs_fallocate
kretprobe:vfs_truncate
kretprobe:vfs_open
[...]
Checklist
  • Language changes are updated in docs/reference_guide.md
  • User-visible and non-trivial changes updated in CHANGELOG.md
  • The new behaviour is covered by tests

Copy link
Member

@danobi danobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a test for uretprobes too?

`bpftrace -l` does not show retprobes (uretprobe, kretprobe, kretfunc)
even if a search keyword is given (e.g., bpftrace -l 'kr:vfs_open'), and
this may confuse users. List retprobes if a user searches them.

Example:

```
% sudo ./src/bpftrace -l 'kr:vfs*'
kretprobe:vfs_fadvise
kretprobe:vfs_fallocate
kretprobe:vfs_truncate
kretprobe:vfs_open
[...]
```
@mmisono
Copy link
Collaborator Author

mmisono commented Aug 26, 2020

Added tests for uretprobe & kretfunc.

@fbs fbs merged commit ae35660 into bpftrace:master Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants