Enable top and div args for printing Type::avg maps #1416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suyuee
changed the title
danobi
requested changes
Jul 14, 2020
fbs
reviewed
Jul 15, 2020
suyuee
force-pushed
the
print_map_avg
branch
2 times, most recently
from
2c9c4a2
to
8d3f9d1
Compare
|
Add runtime tests. |
|
Seems like the test has an off-by-one issue |
suyuee
force-pushed
the
print_map_avg
branch
7 times, most recently
from
7b3d89c
to
3d693b7
Compare
|
Fixed the issue and add a runtime test for json format output. Seems like some tests are queued and won't run. Guess I'll push it later to rerun the tests. |
The top and div arguments of `print()` currently does not work for avg maps because it wasn't implemented. It makes sense to have them supported. Resolves bpftrace#1385.
|
Push again to rerun the tests. |
danobi
approved these changes
Jul 22, 2020
2 tasks
|
Sure, already done:) #1433. |
suyuee
added a commit
to suyuee/bpftrace
that referenced
this pull request
Jul 23, 2020
The merged PR which enables `top` and `div` args of `print` for `avg` maps has two issues that need addressing: 1. It came with subtractions of unsigned integers which can easily cause negative overflows. 2. The runtime tests it came with are somehow unstable and fails randomly. This patch brings more straightforward tests.
2 tasks
suyuee
added a commit
to suyuee/bpftrace
that referenced
this pull request
Jul 23, 2020
The merged PR which enables `top` and `div` args of `print` for `avg` maps has two issues that need addressing: 1. It came with subtractions of unsigned integers which can easily cause negative overflows. 2. The runtime tests it came with are somehow unstable and fails randomly. This patch brings more straightforward tests.
suyuee
added a commit
to suyuee/bpftrace
that referenced
this pull request
Jul 24, 2020
The merged PR which enables `top` and `div` args of `print` for `avg` maps has two issues that need addressing: 1. It came with subtractions of unsigned integers which can easily cause negative overflows. 2. The runtime tests it came with are somehow unstable and fails randomly. This patch brings more straightforward tests.
suyuee
added a commit
to suyuee/bpftrace
that referenced
this pull request
Jul 28, 2020
The merged PR which enables `top` and `div` args of `print` for `avg` maps has two issues that need addressing: 1. It came with subtractions of unsigned integers which can easily cause negative overflows. 2. The runtime tests it came with are somehow unstable and fails randomly. This patch brings more straightforward tests.
danobi
pushed a commit
that referenced
this pull request
Jul 28, 2020
The merged PR which enables `top` and `div` args of `print` for `avg` maps has two issues that need addressing: 1. It came with subtractions of unsigned integers which can easily cause negative overflows. 2. The runtime tests it came with are somehow unstable and fails randomly. This patch brings more straightforward tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The top and div arguments of
print()currently does not work for avg mapsbecause it wasn't implemented. I think it makes sense to have them supported.
Resolves #1385.
Checklist
docs/reference_guide.mdCHANGELOG.md