bpftrace: Fix usdt reads in various architecture #1325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add an entry in the changelog? Other than that, LGTM. |
In USDT tracing, bpftrace uses bcc library function bcc_usdt_get_argument to retrieve the arg passed to the DTRACE_PROBE(). The value present in the arg string is "gprs[0-15]" in s390. However it is named as "r[0-15]" in bpftrace. This leads to offset for register "gprs[0-15]" not known error. Fix this by creating an alias of each register. aarch64 already does it. x86 does have the same convention in bpftrace and bcc. Signed-off-by: Sumanth Korikkar <sumanthk@linux.ibm.com>
sumanthkorikkar
force-pushed
the
usdt-arch-fix
branch
from
47259d7
to
3584aec
Compare
Added
Let me check. Thank you |
danobi
approved these changes
May 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In USDT tracing, bpftrace uses bcc library function
bcc_usdt_get_argument to retrieve the arg passed to the DTRACE_PROBE().
The value present in the arg string is "gprs[0-15]" in s390. However it
is named as "r[0-15]" in bpftrace. This leads to offset for register
"gprs[0-15]" not known error.
Fix this by creating an alias of each register for s390x/ppc64. aarch64 already does it.
x86 does have the same convention in bpftrace and bcc.
Signed-off-by: Sumanth Korikkar sumanthk@linux.ibm.com
Checklist
docs/reference_guide.mdCHANGELOG.md