Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update minimum required version of CMake to 3.8 #1200

Merged
merged 1 commit into from
Apr 14, 2020

Conversation

mmisono
Copy link
Collaborator

@mmisono mmisono commented Mar 13, 2020

CMake 3.8 is required to use C++17.
cf. Kitware/CMake@ae1a681

closes #1193

CMake 3.8 is required to use C++17.
@mmisono
Copy link
Collaborator Author

mmisono commented Mar 13, 2020

It seems Ubuntu 16.04 has CMake 3.5 by default. So users will need to update CMake to build.
alpine 3.8 has CMake 3.11.

@danobi
Copy link
Member

danobi commented Mar 13, 2020

I think @fbs brought up downgrading back to C++14 in IRC. Maybe we should do that for this coming release, then go back up to C++17 and add this change too.

What do you think?

Also, please come join the IRC channel :)

@fbs
Copy link
Contributor

fbs commented Mar 13, 2020

I think @fbs brought up downgrading back to C++14 in IRC. Maybe we should do that for this coming release, then go back up to C++17 and add this change too.

My idea was to do the C++17 right after the 0.9.5 release. That way we can make this the last 16.04 release instead of dropping it half way through without using any features of it yet (like we did now). They can still profit from any improvements that land in 0.9.5 but one that is release 16.04 will be ~4y old so dropping support sounds ok to me

I will add this to the next milestone so we can do it right after we've released

Also, please come join the IRC channel :)

+1

@fbs fbs added this to the 0.11.0 milestone Mar 13, 2020
@fbs fbs added the do-not-merge Changes are not ready to be merged into master yet label Mar 13, 2020
@fbs fbs merged commit 1a1a4a9 into bpftrace:master Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge Changes are not ready to be merged into master yet
Projects
None yet
3 participants