-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: store large checkpoints as multipart upload #5026
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
… multipart uploads
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @sergiupopescu199, it looks good. Left a couple of suggestion to consider/discuss.
…ints as multipart uploads
…checkpoints as multipart uploads
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good with a comment that needs addressing and one more optional nitpick.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice PR @sergiupopescu199 ! From my side in addition only some refinements on documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 🌍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 🎈 great job to the author, and the reviewers!
37fbd23
to
65a3e3a
Compare
Description of change
Add the ability to store large checkpoints as multipart upload on a remote store (e.g AWS S3).
Links to any relevant issues
fixes #4983
Type of change
Choose a type of change, and delete any options that are not relevant.
How the change has been tested
docker/iota-data-ingestion/README.md
instructions of setting up localstack and all the necessary components to test locallyBlobWorker
to accommodate as checkpoint 0 with size around 13GBChange checklist
Tick the boxes that are relevant to your changes, and delete any items that are not.