Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Selective Disclosure Support to VC #144

Closed
2 tasks done
JelleMillenaar opened this issue Mar 2, 2021 · 2 comments · Fixed by #1285 or #1355
Closed
2 tasks done

Add Selective Disclosure Support to VC #144

JelleMillenaar opened this issue Mar 2, 2021 · 2 comments · Fixed by #1285 or #1355
Assignees
Labels
Enhancement New feature or improvement to an existing feature

Comments

@JelleMillenaar
Copy link
Collaborator

JelleMillenaar commented Mar 2, 2021

As an option, update the way verifiable credentials are signed by hashing individual data points inside the credentialSubject object of a verifiable credential using the Merkle Tree algorithm. The last remaining hash is used to sign the verifiable credential. During the revealing of the verifiable credential, fields may either be revealed or may be replaced by its hash.

  • Add option to sign using the Merkle Tree, enabling Selective Disclosure for the Holder
  • Salt the individual fields to prevent brute force guessing
  • Generate Verifiable Presentation while hiding/revealing specific fields in the VC
  • Verify a Verifiable Presentation that is signed with the Selective Disclosure method

For reference: W3C Verifiable Credentials Selective Disclosure

Tasks

Preview Give feedback
  1. UMR1352
  2. wulfraem
@JelleMillenaar JelleMillenaar added the Enhancement New feature or improvement to an existing feature label Mar 2, 2021
@JelleMillenaar JelleMillenaar added this to the Zero Knowledge Proof milestone Jan 25, 2022
@JelleMillenaar
Copy link
Collaborator Author

This issue needs to be reconsidered with our advanced on ZKP. Does the provided ZKP selective disclosure solution provide full benefits over our Merkle Tree algorithm, or does this have advantages over ZKP making it worth implementing?

@eike-hass eike-hass linked a pull request Jan 26, 2024 that will close this issue
10 tasks
@eike-hass
Copy link
Collaborator

The implementation is shifting towards BBS+ based signatures via JWPs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or improvement to an existing feature
Projects
3 participants