Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler): verify parent node when validating component members #5942

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

christian-bromann
Copy link
Member

What is the current behavior?

GitHub Issue Number: fixes #5940

What is the new behavior?

Check for the parent member before calling ts.isClassDeclaration on it.

Documentation

Does this introduce a breaking change?

  • Yes
  • No

Testing

n/a

Other information

n/a

@christian-bromann christian-bromann requested a review from a team as a code owner August 13, 2024 23:53
@christian-bromann christian-bromann added this pull request to the merge queue Aug 14, 2024
Merged via the queue into main with commit 37a0aaf Aug 14, 2024
88 checks passed
@christian-bromann christian-bromann deleted the cb/validate-parent branch August 14, 2024 15:24
@christian-bromann
Copy link
Member Author

This patch has been published in Stencil v4.21.0!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: project builds failing after upgrading to 4.20.0
2 participants