fix(mock-doc): add inert to HTMLAttributes #5072
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
The

inert
attribute fails to type check:fixes: #5071
What is the new behavior?
add
inert
to theHTMLAttributes
interface. this change only allows the attribute to properly type check in TSX. it does not polyfill the functionality for browsers that do not supportinert
.Does this introduce a breaking change?
Testing
Check out and build this branch:
Install it in the output of creating a new stencil component library:
Open
src/components/my-component/my-component.tsx
in your editor, andinert
to a JSX element. It should not properly type check:Other information
STENCIL-1011 bug: Property 'inert' does not exist on type 'HTMLAttributes'