Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decorating an extended element breaks in polyfilled browsers #459

Closed
1 of 3 tasks
mattdsteele opened this issue Jan 30, 2018 · 2 comments
Closed
1 of 3 tasks

Decorating an extended element breaks in polyfilled browsers #459

mattdsteele opened this issue Jan 30, 2018 · 2 comments
Assignees
Labels
Good First Issue This is a good first issue for someone wantng to contribute to Stencil! ionitron: stale issue This issue has not seen any activity for a long period of time

Comments

@mattdsteele
Copy link
Contributor

Stencil version:

 @stencil/core@0.2.3

I'm submitting a:

Current behavior:
So I'd like to extract some common behavior from a few components. My intention was to use mixin classes to accomplish this. This pattern requires extending a class, e.g. class Foo extends withBar()

I'm finding that in polyfilled browsers (Firefox, IE11, Edge), extending any Stencil component causes weird errors, like failing to render at all. This is true even for simple things like class Foo extends Object. I don't see any compiler or run-time errors.

In Chrome it's working fine.

Steps to reproduce:

  1. Clone and npm i https://github.com/mattdsteele/stencil-extended-elements
  2. npm run dev --es5
  3. Open in Firefox and note the <my-component> element, which extends Object, does not render.

Other information:

Other issues make me think this should be possible: #133 (comment), #272

@jgw96 jgw96 added the bug label Jan 30, 2018
@jgw96 jgw96 added this to the 0.4.0 milestone Jan 30, 2018
@adamdbradley
Copy link
Contributor

Related: microsoft/TypeScript#13819

@adamdbradley adamdbradley removed this from the 0.4.0 milestone Feb 7, 2018
@adamdbradley adamdbradley added Good First Issue This is a good first issue for someone wantng to contribute to Stencil! and removed bug labels Feb 7, 2018
@ionitron-bot ionitron-bot bot added the ionitron: stale issue This issue has not seen any activity for a long period of time label Apr 9, 2018
@ionitron-bot
Copy link

ionitron-bot bot commented Apr 9, 2018

Thanks for the issue! This issue is being closed due to inactivity. If this is still an issue with the latest version of Stencil, please create a new issue and ensure the template is fully filled out.

Thank you for using Stencil!

@ionitron-bot ionitron-bot bot closed this as completed Apr 9, 2018
@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Apr 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Good First Issue This is a good first issue for someone wantng to contribute to Stencil! ionitron: stale issue This issue has not seen any activity for a long period of time
Projects
None yet
Development

No branches or pull requests

4 participants