feat(sourcemap): enable rfc-3986 urls

[rwaskiewicz]

Pull request checklist

Please check if your PR fulfills the following requirements:

• Tests for the changes have been added (for bug fixes / features)
• Docs have been reviewed and added / updated if needed (for bug fixes / features)
• Build (npm run build) was run locally and any changes were pushed
• Unit tests (npm test) were run locally and passed
• E2E Tests (npm run test.karma.prod) were run locally and passed
• Prettier (npm run prettier) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

• Bugfix
• Feature
• Refactoring (no functional changes, no api changes)
• Build related changes
• Documentation content changes
• Other (please describe):

What is the current behavior?

Today, sourcemap urls generated by Stencil work, but are not compliant with the sourcemap spec

GitHub Issue Number: N/A

What is the new behavior?

ensure that sourceMapUrls are compliant with RFC-3986, per the sourcemap
specification:

Note: is a URL as defined in RFC3986; in particular, characters
outside the set permitted to appear in URIs must be percent-encoded.

STENCIL-173: Make sourceMapUrl values RFC 3986 compliant

Does this introduce a breaking change?

• Yes
• No - I suppose one could interpret it as such in a way though....

Testing

https://github.com/rwaskiewicz/stencil-sourcemap-rfc3986/commits/main demonstrates how I tested this. Looking through the history of that repro:

• rwaskiewicz/stencil-sourcemap-rfc3986@a7bd061 is the output of npm init stencil for a component library
• rwaskiewicz/stencil-sourcemap-rfc3986@92b1e64 runs npm i
• rwaskiewicz/stencil-sourcemap-rfc3986@f69833b is where I installed a local build of Stencil in the repro. To do so yourself:
  • pull down this PR
  • npm ci && npm run build && npm pack
  • navigate to a clone of https://github.com/rwaskiewicz/stencil-sourcemap-rfc3986, run npm i <PATH_TO_TARBALL>
• rwaskiewicz/stencil-sourcemap-rfc3986@0d2af28 enables sourcemaps, minification in the Stencil config
• rwaskiewicz/stencil-sourcemap-rfc3986@958248d renames my-component.tsx to use most of the RFC 3986 chars (omitting the single quote)
• rwaskiewicz/stencil-sourcemap-rfc3986@55e3726 renames utils/utils.ts to use all rfc 2986 chars

I then ran npm start and validated that sourcemaps look a-okay:

Oh, and this is unit tested as well 🙂

Other information