Skip to content

Commit f73aa14

Browse files
authored
feat(declarations): add popover attributes to JSX declarations (#5064)
* feat(declarations): add popover attributes * align types with lib.dom.ts types * add comment
1 parent 91cfa2c commit f73aa14

File tree

1 file changed

+15
-0
lines changed

1 file changed

+15
-0
lines changed

src/declarations/stencil-public-runtime.ts

+15
Original file line numberDiff line numberDiff line change
@@ -899,6 +899,11 @@ export namespace JSXBase {
899899
name?: string;
900900
type?: string;
901901
value?: string | string[] | number;
902+
903+
// popover
904+
popoverTargetAction?: string;
905+
popoverTargetElement?: Element | null;
906+
popoverTarget?: string;
902907
}
903908

904909
export interface CanvasHTMLAttributes<T> extends HTMLAttributes<T> {
@@ -1074,6 +1079,11 @@ export namespace JSXBase {
10741079
webkitdirectory?: boolean;
10751080
webkitEntries?: any;
10761081
width?: number | string;
1082+
1083+
// popover
1084+
popoverTargetAction?: string;
1085+
popoverTargetElement?: Element | null;
1086+
popoverTarget?: string;
10771087
}
10781088

10791089
export interface KeygenHTMLAttributes<T> extends HTMLAttributes<T> {
@@ -1365,6 +1375,11 @@ export namespace JSXBase {
13651375
tabIndex?: number;
13661376
tabindex?: number | string;
13671377
title?: string;
1378+
// These types don't allow you to use popover as a boolean attribute
1379+
// so you can't write HTML like `<div popover>` and get the default value.
1380+
// Developer must explicitly specify one of the valid popover values or it will fallback
1381+
// to `manual` (following the HTML spec).
1382+
popover?: string | null;
13681383

13691384
// Unknown
13701385
inputMode?: string;

0 commit comments

Comments
 (0)