chore(deps): upgrade typescript to 5.1.6 (#4718)

This release includes various refinements and improvements. One thing if
fixes is an issue where previously an exported class declaration that
included a static property would be not have the export keyword put
directly on the class declaration, but instead the symbol would be
exported.

So with the following typescript:

```ts
export class MyClass {
  static foobar: string = "baz";
}
```

the compiler would emit code like this:

```js
class MyClass {
  static foobar = "baz";
}
export { MyClass }
```

instead of

```js
export class MyClass {
  static foobar = "baz;
}
```

The former output causes an issue with Rollup, so that issue being fixed
is part of the impetus for this upgrade.

Try this out [here on the TS
playground](https://www.typescriptlang.org/play?useDefineForClassFields=true&target=9&ts=5.1.6&ssl=1&ssc=1&pln=3&pc=1#code/KYDwDg9gTgLgBAYwDYEMDOa4GFUbgbwFgAoOMuNGFGASwTgDNoBbAQQwgRuuABM4AvHBhQArsADcJAL5A)
to confirm (toggle between version 5.1 and 5.2 and look at the change in
output).

See <https://www.typescriptlang.org/docs/handbook/release-notes/typescript-5-1.html>
for a full list of changes and improvements.

Co-authored-by: Ryan Waskiewicz <ryanwaskiewicz@gmail.com>

Author: alicewriteswrongs

package-lock.json

@@ -122,7 +122,7 @@
     "semver": "^7.3.7",
     "sizzle": "^2.3.6",
     "terser": "5.19.2",
-    "typescript": "~5.0.4",
+    "typescript": "~5.1.6",
     "webpack": "^5.75.0",
     "ws": "8.13.0"
   },

package.json

@@ -63,7 +63,7 @@
     {
       // TODO(STENCIL-710): Increment this value as a part of updating TypeScript
       matchPackageNames: ['typescript'],
-      allowedVersions: '<5.0.0',
+      allowedVersions: '<5.1.6',
     },
     {
       // disable Jest updates until the new testing architecture is in place

renovate.json5

@@ -17,7 +17,7 @@ export const updateLazyComponentClass = (
   cmp: d.ComponentCompilerMeta,
 ) => {
   const members = updateLazyComponentMembers(transformOpts, styleStatements, classNode, moduleFile, cmp);
-  return updateComponentClass(transformOpts, classNode, classNode.heritageClauses, members, moduleFile);
+  return updateComponentClass(transformOpts, classNode, classNode.heritageClauses, members);
 };
 
 const updateLazyComponentMembers = (

src/compiler/transformers/component-lazy/lazy-component.ts

@@ -21,7 +21,7 @@ export const updateNativeComponentClass = (
 ): ts.ClassDeclaration | ts.VariableStatement => {
   const heritageClauses = updateNativeHostComponentHeritageClauses(classNode, moduleFile);
   const members = updateNativeHostComponentMembers(transformOpts, classNode, moduleFile, cmp);
-  return updateComponentClass(transformOpts, classNode, heritageClauses, members, moduleFile);
+  return updateComponentClass(transformOpts, classNode, heritageClauses, members);
 };
 
 /**

src/compiler/transformers/component-native/native-component.ts

@@ -2,14 +2,8 @@ import { augmentDiagnosticWithNode, buildError } from '@utils';
 import ts from 'typescript';
 
 import type * as d from '../../../declarations';
-import {
-  convertValueToLiteral,
-  createStaticGetter,
-  retrieveTsDecorators,
-  retrieveTsModifiers,
-} from '../transform-utils';
+import { retrieveTsDecorators, retrieveTsModifiers } from '../transform-utils';
 import { componentDecoratorToStatic } from './component-decorator';
-import { hasStaticInitializerInClass } from './convert-static-members';
 import { isDecoratorNamed } from './decorator-utils';
 import {
   CLASS_DECORATORS_TO_REMOVE,
@@ -88,14 +82,6 @@ const visitClassDeclaration = (
     listenDecoratorsToStatic(diagnostics, decoratedMembers, filteredMethodsAndFields);
   }
 
-  // Handle static members that are initialized
-  const hasStaticMembersWithInit = classMembers.some(hasStaticInitializerInClass);
-  if (hasStaticMembersWithInit) {
-    filteredMethodsAndFields.push(
-      createStaticGetter('stencilHasStaticMembersWithInit', convertValueToLiteral(hasStaticMembersWithInit)),
-    );
-  }
-
   // We call the `handleClassFields` method which handles transforming any
   // class fields, removing them from the class and adding statements to the
   // class' constructor which instantiate them there instead.

src/compiler/transformers/decorators-to-static/convert-decorators.ts

@@ -38,7 +38,6 @@ const REMOVE_STATIC_GETTERS = new Set([
   'methods',
   'states',
   'originalStyleUrls',
-  'stencilHasStaticMembersWithInit',
   'styleMode',
   'style',
   'styles',

src/compiler/transformers/decorators-to-static/convert-static-members.ts

@@ -61,7 +61,6 @@ export const parseStaticComponentMeta = (
     componentClassName: cmpNode.name ? cmpNode.name.text : '',
     elementRef: parseStaticElementRef(staticMembers),
     encapsulation,
-    hasStaticInitializedMember: getStaticValue(staticMembers, 'stencilHasStaticMembersWithInit') ?? false,
     shadowDelegatesFocus: parseStaticShadowDelegatesFocus(encapsulation, staticMembers),
     properties: parseStaticProps(staticMembers),
     virtualProperties: parseVirtualProps(docs),