Skip to content

Commit 3b480c6

Browse files
committed
feat(output_targets): remove legacy angular target (#3493)
this commit removes the legacy angular output target from the core compiler. stencil no longer places framework output targets within the compiler directly. instead, developers should be using the angular output target that is maintained by the stencil/ionic framework teams, located at https://www.npmjs.com/package/@stencil/angular-output-target Documentation for getting started with the Angular Framework Wrapper can be found at: https://stenciljs.com/docs/angular BREAKING CHANGE: Removed the legacy Angular output target. Users should migrate to https://www.npmjs.com/package/@stencil/angular-output-target
1 parent 674bf51 commit 3b480c6

File tree

6 files changed

+0
-297
lines changed

6 files changed

+0
-297
lines changed

src/compiler/config/outputs/index.ts

-2
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ import {
66
isValidConfigOutputTarget,
77
VALID_CONFIG_OUTPUT_TARGETS,
88
} from '../../output-targets/output-utils';
9-
import { validateAngular } from './validate-angular';
109
import { validateCollection } from './validate-collection';
1110
import { validateCustomElement } from './validate-custom-element';
1211
import { validateCustomElementBundle } from './validate-custom-element-bundle';
@@ -43,7 +42,6 @@ export const validateOutputTargets = (config: d.ValidatedConfig, diagnostics: d.
4342
...validateWww(config, diagnostics, userOutputs),
4443
...validateDist(config, userOutputs),
4544
...validateDocs(config, diagnostics, userOutputs),
46-
...validateAngular(config, userOutputs),
4745
...validateStats(config, userOutputs),
4846
];
4947

src/compiler/config/outputs/validate-angular.ts

-33
This file was deleted.

src/compiler/output-targets/index.ts

-2
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ import { outputCustomElements } from './dist-custom-elements';
77
import { outputCustomElementsBundle } from './dist-custom-elements-bundle';
88
import { outputHydrateScript } from './dist-hydrate-script';
99
import { outputLazy } from './dist-lazy/lazy-output';
10-
import { outputAngular } from './output-angular';
1110
import { outputDocs } from './output-docs';
1211
import { outputLazyLoader } from './output-lazy-loader';
1312
import { outputTypes } from './output-types';
@@ -29,7 +28,6 @@ export const generateOutputTargets = async (
2928
invalidateRollupCaches(compilerCtx);
3029

3130
await Promise.all([
32-
outputAngular(config, compilerCtx, buildCtx),
3331
outputCopy(config, compilerCtx, buildCtx),
3432
outputCollection(config, compilerCtx, buildCtx, changedModuleFiles),
3533
outputCustomElements(config, compilerCtx, buildCtx),

src/compiler/output-targets/output-angular.ts

-245
This file was deleted.

src/compiler/output-targets/output-utils.ts

-4
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,6 @@ export const isOutputTargetCopy = (o: d.OutputTarget): o is d.OutputTargetCopy =
3636

3737
export const isOutputTargetDistLazy = (o: d.OutputTarget): o is d.OutputTargetDistLazy => o.type === DIST_LAZY;
3838

39-
export const isOutputTargetAngular = (o: d.OutputTarget): o is d.OutputTargetAngular => o.type === ANGULAR;
40-
4139
export const isOutputTargetDistLazyLoader = (o: d.OutputTarget): o is d.OutputTargetDistLazyLoader =>
4240
o.type === DIST_LAZY_LOADER;
4341

@@ -70,7 +68,6 @@ export const isOutputTargetDistTypes = (o: d.OutputTarget): o is d.OutputTargetD
7068
export const getComponentsFromModules = (moduleFiles: d.Module[]) =>
7169
sortBy(flatOne(moduleFiles.map((m) => m.cmps)), (c: d.ComponentCompilerMeta) => c.tagName);
7270

73-
export const ANGULAR = 'angular';
7471
export const COPY = 'copy';
7572
export const CUSTOM = 'custom';
7673
export const DIST = 'dist';
@@ -115,7 +112,6 @@ export const VALID_CONFIG_OUTPUT_TARGETS = [
115112
DOCS_CUSTOM,
116113

117114
// MISC
118-
ANGULAR,
119115
COPY,
120116
CUSTOM,
121117
STATS,

src/declarations/stencil-public-compiler.ts

-11
Original file line numberDiff line numberDiff line change
@@ -2071,16 +2071,6 @@ export interface OutputTargetBase {
20712071

20722072
export type OutputTargetBuild = OutputTargetDistCollection | OutputTargetDistLazy;
20732073

2074-
export interface OutputTargetAngular extends OutputTargetBase {
2075-
type: 'angular';
2076-
2077-
componentCorePackage: string;
2078-
directivesProxyFile?: string;
2079-
directivesArrayFile?: string;
2080-
directivesUtilsFile?: string;
2081-
excludeComponents?: string[];
2082-
}
2083-
20842074
export interface OutputTargetCopy extends OutputTargetBase {
20852075
type: 'copy';
20862076

@@ -2173,7 +2163,6 @@ export interface OutputTargetWww extends OutputTargetBase {
21732163
}
21742164

21752165
export type OutputTarget =
2176-
| OutputTargetAngular
21772166
| OutputTargetCopy
21782167
| OutputTargetCustom
21792168
| OutputTargetDist

0 commit comments

Comments
 (0)