Skip to content

Commit 2cec0a6

Browse files
authored
fix(runtime): autocapitalize property is a string (#3692)
In #2509, we changed these types to `any` as suggested by Manu. This was done to fix ionic-team/ionic-framework#21464. Upon further investigation we found that this fix was not correct. The Framework issue had nothing to do with the types on `HTMLStencilElement` and instead were related to the types on `HTMLElement`. It's worth noting we didn't got the route of specifying the allowed strings further to `'off' | 'on' | 'none' | 'sentences' | 'words' | 'characters'` to align with `lib.dom.d.ts` that's shipped with TypeScript, which just types this property as `string` (on `HTMLElement`). Had we done that, we could/would have run into issues where `string` isn't assignable to `'off' | 'on' | 'none' | 'sentences' | 'words' | 'characters'`, as the former is wider than that latter.
1 parent d4af185 commit 2cec0a6

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

src/declarations/stencil-public-runtime.ts

+4-4
Original file line numberDiff line numberDiff line change
@@ -929,8 +929,8 @@ export namespace JSXBase {
929929
accept?: string;
930930
allowdirs?: boolean;
931931
alt?: string;
932-
autoCapitalize?: any;
933-
autocapitalize?: any;
932+
autoCapitalize?: string;
933+
autocapitalize?: string;
934934
autoComplete?: string;
935935
autocomplete?: string;
936936
autoFocus?: boolean;
@@ -1292,8 +1292,8 @@ export namespace JSXBase {
12921292
vocab?: string;
12931293

12941294
// Non-standard Attributes
1295-
autoCapitalize?: any;
1296-
autocapitalize?: any;
1295+
autoCapitalize?: string;
1296+
autocapitalize?: string;
12971297
autoCorrect?: string;
12981298
autocorrect?: string;
12991299
autoSave?: string;

0 commit comments

Comments
 (0)