Skip to content

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Sep 12, 2023

While working with Mike to test StarTrack, we discovered that mapping the same icon twice yields a warning when it should not.

Example

addIcons({ logoIonic });
addIcons({ logoIonic });

This can happen in an application where same icon is used in multiple places. In that case it's necessary to call addIcons since we don't know which place will be loaded first. In this case, no warning should be logged since these are the same icon references.

@liamdebeasi liamdebeasi changed the title Icon warn fix fix(icon): mapping same icon does not warn Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants