New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Last change in diagnostic.ts breaks build when using noImplicitAny option #905

Closed

Ritzlgrmft opened this issue Dec 22, 2016 · 1 comment

Contributor

Ritzlgrmft commented Dec 22, 2016

The last change in diagnostic.ts breaks the build, when the typescript option noImplicitAny is used, since the generated diagnostic.d.ts contains

    static permissionStatus: {
        GRANTED;
        DENIED;
        NOT_REQUESTED;
        DENIED_ALWAYS;
        RESTRICTED;
        GRANTED_WHEN_IN_USE;
    };

Apparently, GRANTED etc. do not have a type declaration.

It would be great if you could add the types again, so I could enable noImplicitAny again.

The text was updated successfully, but these errors were encountered:

ihadeed closed this as completed in

Collaborator

ihadeed commented Dec 27, 2016

Just pushed a commit that should fix it, will publish a release soon once I'm done reviewing other issues/PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment