fix(ftp): return observable (not promise) for upload and download method #2174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
b73e437 is a duplicate of #2178 Your fix is of course correct, but in the future try addressing one distinct issue per PR You named your commit correctly and your PR should be named the same thing: "fix(ftp): return observable (not promise) for upload and download method" (I tried shortening it) Solid 💯 |
poldiwa
changed the title
|
sorry but the linting was causing a build failure so yeah did it too lol. @josharmstrong08 is it still gonna be accepted? What can I do with the mistake |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #2147
I'm a newbie, I hope someone could help me edit my PR, if anything looks wrong with it.