Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

routeWithNavController in deeplinks.d.ts missing options parameter #1601

Closed
petemcwilliams opened this issue May 24, 2017 · 0 comments
Closed

Comments

@petemcwilliams
Copy link

I'm submitting a ... (check one with "x")
[ ] bug report
[x] feature request

Current behavior:
Unable to specify options in deeplinks typescript.

[10:29:21] transpile started ...
[10:29:24] typescript: src/app/app.component.ts, line: 262
Supplied parameters do not match any signature of call target.

[10:29:24] transpile failed

Expected behavior:
Allow optional value of {root: true}

Steps to reproduce:
Use code below.

Related code:

Deeplinks.routeWithNavController(
    this.app.getActiveNav(),
    {
        // routes 
    },
    {
        root: true
    }
).subscribe((match) => {
     console.error('Got a deeplink match', match);
}, (nomatch) => {
    console.error('Got a deeplink that didn\'t match', nomatch);
});

Other information:
described ionic-team/ionic-plugin-deeplinks#29

package.json info:

        "@angular/common": "2.4.8",
        "@angular/compiler": "2.4.8",
        "@angular/compiler-cli": "2.4.8",
        "@angular/core": "2.4.8",
        "@angular/forms": "2.4.8",
        "@angular/http": "2.4.8",
        "@angular/platform-browser": "2.4.8",
        "@angular/platform-browser-dynamic": "2.4.8",
        "@angular/platform-server": "2.4.8",
        "ionic-angular": "2.2.0",
        "ionic-native": "^2.9.0",
        "ionicons": "3.0.0",
        "rxjs": "5.0.1",
        "sw-toolbox": "3.4.0",
        "zone.js": "0.7.2"
harshithkashyap added a commit to harshithkashyap/ionic-native that referenced this issue Nov 22, 2017
harshithkashyap added a commit to harshithkashyap/ionic-native that referenced this issue Nov 22, 2017
harshithkashyap added a commit to harshithkashyap/ionic-native that referenced this issue Nov 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant