fix(core): add an export map to import individual components #29717
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Thanks @sean-perkins for the feedback, I applied suggested improvements. |
|
@christian-bromann it looks like the For the angular build issues/test issues, you should see this error: we should export the loader path as well for the lazy loaded distribution. |
christian-bromann
force-pushed
the
cb/module-resolution
branch
from
f95bf0f
to
47b4a0c
Compare
There was a problem hiding this comment.
Looks good to me 👍
We should definitely get someone from the Ionic Framework team to look at this for visibility to the change/impacts.
There is some risk that we are missing exporting an obscure build file that is not leveraged in Ionic Framework's packages/test apps, but a developer is making use of. I still think we could publish this as a patch or minor and if those cases are reported, we add the missing exports paths/evaluate what files are being consumed.
sean-perkins
requested review from
brandyscarney and
thetaPC
and removed request for
joselrio
| "import": "./components/ion-accordion.js", | ||
| "types": "./components/ion-accordion.d.ts" | ||
| }, | ||
| "./ion-avatar": { |
There was a problem hiding this comment.
What's the reason for not including ion-action-sheet, ion-alert, and others that are missing?
What is the current behavior?
The core package doesn't provide an export map, which prevents modern code bases to import specific components.
fixes #29716
What is the new behavior?
This patch contains:
nodetobundlerin the `moduleResolution field, both resolutions are very similar - changing this has no impact on the user as it is only for internal developmentDoes this introduce a breaking change?
This should not impact users at all but enable them to use a different module resolution. However, I may not be too familiar how Ionic components are imported, therefor it would be good to do some thorough testing.
Other information
n/a