Skip to content

Commit 4c90830

Browse files
authoredJun 27, 2024··
chore(angular-server): add sync github action and update @stencil/core to 4.19.1 in core (#29670)
Issue number: internal --------- This does a couple things: **1 - Adds a `sync` command to get the latest `core` build in `angular-server`** The release process for `angular-server` failed [here](https://github.com/ionic-team/ionic-framework/actions/runs/9686982182/job/26730689874). This failure was only made apparent because the Lerna command [here](https://github.com/ionic-team/ionic-framework/blob/52ff0505e86dc204cb2fd2fdaf67229e6eeb36f8/.github/workflows/actions/publish-npm/action.yml#L35) runs prior to building each package. This should have been caught by CI on the [update to @stencil/core to v4.19.0](#29666), but the `angular-server` package is the only package that doesn't sync `core` before it builds. This PR adds a `sync` command so that `angular-server` will use the latest core build during the normal build action. **2 - Resolving types errors in `angular-server`** After properly syncing `core` in `angular-server` using the command added, running build fails with the following: <img width="400px" alt="Screenshot 2024-06-27 at 1 16 15 PM" src="https://github.com/ionic-team/ionic-framework/assets/6577830/68d74750-821b-4776-b563-124d8fa06a79"> This was a regression in Stencil. `@stencil/core` has been updated to resolve these errors so the build passes.
1 parent 52ff050 commit 4c90830

File tree

6 files changed

+64
-13
lines changed

6 files changed

+64
-13
lines changed
 

‎.github/workflows/actions/build-angular-server/action.yml

+9-1
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,19 @@ runs:
66
- uses: actions/setup-node@v4
77
with:
88
node-version: 18.x
9-
9+
- uses: ./.github/workflows/actions/download-archive
10+
with:
11+
name: ionic-core
12+
path: ./core
13+
filename: CoreBuild.zip
1014
- name: Install Angular Server Dependencies
1115
run: npm ci
1216
shell: bash
1317
working-directory: ./packages/angular-server
18+
- name: Sync
19+
run: npm run sync
20+
shell: bash
21+
working-directory: ./packages/angular-server
1422
- name: Build
1523
run: npm run build.prod
1624
shell: bash

‎core/package-lock.json

+8-10
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎core/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
"loader/"
3232
],
3333
"dependencies": {
34-
"@stencil/core": "^4.19.0",
34+
"@stencil/core": "^4.19.1",
3535
"ionicons": "^7.2.2",
3636
"tslib": "^2.1.0"
3737
},

‎packages/angular-server/package-lock.json

+31
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎packages/angular-server/package.json

+3-1
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,8 @@
3232
"lint": "eslint . --ext .ts && npm run prettier",
3333
"lint.fix": "eslint . --ext .ts --fix && npm run prettier.fix",
3434
"prettier": "prettier \"**/*.ts\" --check",
35-
"prettier.fix": "prettier \"**/*.ts\" --write"
35+
"prettier.fix": "prettier \"**/*.ts\" --write",
36+
"sync": "sh ./scripts/sync.sh"
3637
},
3738
"peerDependencies": {
3839
"@angular/core": ">=16.0.0",
@@ -52,6 +53,7 @@
5253
"@angular/platform-server": "^16.0.0",
5354
"@ionic/eslint-config": "^0.3.0",
5455
"@ionic/prettier-config": "^2.0.0",
56+
"@types/node": "^20.14.9",
5557
"@typescript-eslint/eslint-plugin": "^5.2.0",
5658
"eslint": "^7.32.0",
5759
"eslint-plugin-import": "^2.25.2",
+12
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
#!/bin/bash
2+
3+
set -e
4+
5+
# Delete old packages
6+
rm -f *.tgz
7+
8+
# Pack @ionic/core
9+
npm pack ../../core
10+
11+
# Install Dependencies
12+
npm install *.tgz --no-save

0 commit comments

Comments
 (0)
Please sign in to comment.