From 008b4e6dff3c6b92feec4b4e29ebe3d827886b3b Mon Sep 17 00:00:00 2001 From: IT-MikeS <20338451+IT-MikeS@users.noreply.github.com> Date: Tue, 28 Mar 2023 12:09:03 -0400 Subject: [PATCH] fix(cli): Fix cordova plugin config checker over checking --- cli/src/cordova.ts | 31 +++++++++++++++++++------------ 1 file changed, 19 insertions(+), 12 deletions(-) diff --git a/cli/src/cordova.ts b/cli/src/cordova.ts index 62856dc86b..216e465cf8 100644 --- a/cli/src/cordova.ts +++ b/cli/src/cordova.ts @@ -954,19 +954,26 @@ export async function writeCordovaAndroidManifest( } } } else { - let foundRequiredElement = false; - for (const existingElementItem of existingElement.children) { - const foundRequiredElementIn = doesElementMatch( - requiredElement, - existingElementItem, - ); - if (foundRequiredElementIn) { - foundRequiredElement = true; - break; + if ( + requiredElement.children === undefined && + existingElement.children === undefined + ) { + return true; + } else { + let foundRequiredElement = false; + for (const existingElementItem of existingElement.children) { + const foundRequiredElementIn = doesElementMatch( + requiredElement, + existingElementItem, + ); + if (foundRequiredElementIn) { + foundRequiredElement = true; + break; + } + } + if (!foundRequiredElement) { + return false; } - } - if (!foundRequiredElement) { - return false; } } }