fix(cli): enable cleartext for live reload #7563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcesarmobile
requested review from
IT-MikeS,
andredestro,
markemer,
EiyuuZack,
theproducer and
nflsilva
markemer
approved these changes
Jul 16, 2024
IT-MikeS
approved these changes
Jul 17, 2024
jcesarmobile
added a commit
that referenced
this pull request
Jul 26, 2024
jcesarmobile
added a commit
that referenced
this pull request
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables cleartext when using live reload by directly writing into the
capacitor-cordova-android-plugins'sAndroidManifest.xml, and removes it once the command is stopped.It no longer overrides the original
extConfigobject but instead modifies the platform'scapacitor.config.jsonafter sync.Added a TODO to remove
editExtConfigForLiveReloadsince it's no longer being used.Added a TODO to remove the last param of
editCapConfigForLiveReloadas it's not being used.Didn't remove any of them at the moment as people could be using the
CapLiveReloadHelperdirectly, so removing them is breaking.I've put the
process.on('SIGINT'inside a promise to prevent multiple calls, it was being called three times.There is an alternate PR, but it requires users to declare the
cleartextthemselves and doesn't work if using the--no-syncoption.closes #7323
closes #7528