fix(android): UTF-8 encode form data value #7525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malo-malo
changed the title
3 tasks
android/capacitor/src/main/java/com/getcapacitor/plugin/util/CapacitorHttpUrlConnection.java
Outdated
Show resolved
Hide resolved
Co-authored-by: jcesarmobile <jcesarmobile@gmail.com>
jcesarmobile
approved these changes
Jun 21, 2024
jcesarmobile
requested review from
andredestro,
markemer,
EiyuuZack,
theproducer,
nflsilva,
ItsChaceD and
IT-MikeS
markemer
approved these changes
Jun 21, 2024
jcesarmobile
added a commit
that referenced
this pull request
Jun 24, 2024
Co-authored-by: Malo <malo.c@hellowatt.fr> Co-authored-by: jcesarmobile <jcesarmobile@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using multipart/form-data in a POST request on Android, the values are not encoded, which is problematic when the values contain accents or emojis for example
This merge request proposes to encode values in UTF-8, similar to what is done when encoding other POST requests body
Fixes #7526
closes #7219
closes #6730