feat(android): Load alternative layout when no WebView #7141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcesarmobile
requested review from
markemer,
theproducer,
ItsChaceD,
IT-MikeS and
giralte-ionic
giralte-ionic
approved these changes
Dec 18, 2023
markemer
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a basic layout with a text error message for when there is no WebView installed on the device or is disabled.
Users can use their own text by adding a
<string name="no_webview_text">custom text</string>entry in theirstrings.xml, or create their ownno_webview.xmllayout that would replace Capacitor's default one.Added some
bridge != nullchecks as if the app fails to create the WebView, thebridgewill be null and crash.closes #5257