feat(ios): Add Codable support for CAPPluginCall and JSValueContainer #7119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Steven0351
requested review from
markemer,
theproducer,
ItsChaceD,
giralte-ionic,
IT-MikeS and
jcesarmobile
that indicates that the method will throw if the value attempted to be decoded is a class type.
giralte-ionic
approved these changes
Dec 11, 2023
theproducer
approved these changes
Dec 11, 2023
markemer
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the initial
Codablesupport forJSValue. It includes a custom Encoder and Decoder as well as extensions onCAPPluginCallandJSValueContainer.On another note, a few changes were made to make the tests compile as well. It may be a good idea to start running those as part of CI since the test suite is beginning to grow and could catch regressions before we ship them.