Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): launching intents without host #6489

Merged
merged 2 commits into from
Apr 11, 2023
Merged

fix(android): launching intents without host #6489

merged 2 commits into from
Apr 11, 2023

Conversation

jcesarmobile
Copy link
Member

url can be a tel: or mailto: or other app urls that will not include a host, which will make the app to crash because of using equals on a null object.
Reversing the check order, since appUri will always have a host, it will not crash.

closes #6483

@theproducer
Copy link
Contributor

Looks like something related to Minipass is causing build errors

@jcesarmobile jcesarmobile merged commit 95f7474 into main Apr 11, 2023
@jcesarmobile jcesarmobile deleted the null-host branch April 11, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tel: links throw exception
4 participants