Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ios): Prevent Xcode 14 warning on CAPWebView #5821

Merged
merged 2 commits into from
Aug 3, 2022
Merged

fix(ios): Prevent Xcode 14 warning on CAPWebView #5821

merged 2 commits into from
Aug 3, 2022

Conversation

jcesarmobile
Copy link
Member

@jcesarmobile jcesarmobile commented Aug 3, 2022 •
edited
Loading

Xcode 14 shows this warning:

Non-'@objc' instance method in extensions cannot be overridden; use 'public' instead

And proposes to change to public, so I've done that

Closes #5819

@jcesarmobile jcesarmobile merged commit 66954ef into main Aug 3, 2022
@jcesarmobile jcesarmobile deleted the fix-warning branch August 3, 2022 17:06
@sync-by-unito sync-by-unito bot mentioned this pull request Sep 1, 2022
Closed
@sync-by-unito sync-by-unito bot mentioned this pull request Sep 13, 2022
Closed
@sync-by-unito sync-by-unito bot mentioned this pull request Oct 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IT-MikeS IT-MikeS IT-MikeS approved these changes

@Steven0351 Steven0351 Steven0351 approved these changes

@giralte-ionic giralte-ionic Awaiting requested review from giralte-ionic

@theproducer theproducer Awaiting requested review from theproducer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong access specifier
3 participants
@jcesarmobile @IT-MikeS @Steven0351