-
Notifications
You must be signed in to change notification settings - Fork 997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): Add --forwardPorts option to Capacitor CLI #5645
Conversation
…to automatically run an adb reverse
@thomasvidas any new about this feature ? |
I'd be keen on this one landing too! Hit an issue today where manual port forwards are cleared by |
I've updated this to be merged to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not working, the forwardPorts option is not being passed to the runCommand, should look like this:
async (platform, { scheme, flavor, list, target, sync, forwardPorts }) => {
const { runCommand } = await import('./tasks/run');
await runCommand(config, platform, {
scheme,
flavor,
list,
target,
sync,
forwardPorts
});
},
Huh, it worked for @theproducer - I'll take a look |
It does seem like that is missing. |
Co-authored-by: Mark Anderson <mark@ionic.io>
Exposes the
--forwardPorts
option from native-run to the Capacitor CLI. When annpx cap run android --forwardPorts 8000:8000
is run, the following happens.adb reverse tcp:${port} tcp:${port}
Opening as a Draft PR because
--live-reload
flag with the port in the config makes more sense?