Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ios): Add overrideable routing for CAPBridgeViewController subclasses #5546

Merged
merged 4 commits into from
Mar 30, 2022

Conversation

Steven0351
Copy link
Member

No description provided.

}

// swiftlint:disable:next type_name
internal struct _Router: Router {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I disabled the swiftlint violation here because this is common practice in the Swift standard library to use an _ prefix for non-public types

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with naming it something different if that's what we want to do as well.

@Steven0351 Steven0351 merged commit 8875d5e into main Mar 30, 2022
@Steven0351 Steven0351 deleted the portals-routing branch March 30, 2022 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants