Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): restrict android run command to configured flavour #5256

Merged

Conversation

sandor-biro
Copy link
Contributor

Solves request: #5252

Live reload should now work with any productFlavor.

@sandor-biro sandor-biro changed the title feat(android): added flavor support for android --livereload feat(android): Added flavor support for android --livereload Nov 19, 2021
@@ -19,7 +19,8 @@ export async function runAndroid(
selectedTarget,
);

const gradleArgs = ['assembleDebug'];
const arg = `assemble${config.android?.flavor || ''}Debug`;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sandor-biro You still need the word Debug, the correct argument is actually assembleFlavorDebug where Flavor is the value from the config

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Debug word is at the end of the template string, so if there is a flavor it will be assembleFlavorNameDebug and if not assembleDebug

@carlpoole
Copy link
Member

Can you run npm run fmt and commit the changes please

@carlpoole carlpoole changed the title feat(android): Added flavor support for android --livereload fix(android): restrict android run command to configured flavour if exists in config Nov 22, 2021
@carlpoole carlpoole changed the title fix(android): restrict android run command to configured flavour if exists in config fix(android): restrict android run command to configured flavour Nov 22, 2021
@carlpoole carlpoole merged commit ba84443 into ionic-team:main Nov 22, 2021
@sandor-biro sandor-biro deleted the android-livereload-support-flavour branch November 23, 2021 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants