Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): Put cordova git pod dependencies in Podfile #4940

Merged
merged 1 commit into from
Aug 18, 2021

Conversation

jcesarmobile
Copy link
Member

Some Cordova plugins are using pod dependencies directly from GitHub, as they don't have a version we just add a dependency in the podspec, but if it's not published in CocoaPods repo Capacitor won't find it.

This PR will read pod entries in plugin.xml and if they are git references it will put them in the users Podfile with the other Capacitor dependencies so it can be found.

closes #4867

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Cordova plugin's podspec entries not added to iOS project's Podfile
2 participants