Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Call native implementation before web implementation #4493

Merged
merged 7 commits into from
Apr 27, 2021

Conversation

jcesarmobile
Copy link
Member

On plugins that mix native and web implementations, current implementation causes an infinite loop because it always tries to use the web implementation before the native implementation, so when it reaches Plugins.PluginName, it tries to call the native code, but the proxy returns the web code, which tries to call the native code again and causes the infinite loop.

By changing the order, it will use the native code if available, and if not, use the web implementation.

closes #4492

@jcesarmobile jcesarmobile merged commit febd606 into main Apr 27, 2021
@jcesarmobile jcesarmobile deleted the fix-web-mix branch April 27, 2021 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GetPreferred hangs in TextZoom plugin on IOS
2 participants