Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): use more explicit result for Browser plugin events #3349

Merged
merged 3 commits into from
Jul 28, 2020

Conversation

jcesarmobile
Copy link
Member

Related to a comment on #3044 that says that using any is misleading, which I agree.

At the moment both events return {}, so created a new type that is just that.

But would probably be better to make the event listener function to not return anything (would require native code changes as they return the empty object now)

@imhoffd imhoffd merged commit 75f99d4 into ionic-team:main Jul 28, 2020
@imhoffd imhoffd deleted the browser-info-types branch July 28, 2020 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants