Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): switch to Github Actions #3057

Merged
merged 4 commits into from
Jun 5, 2020
Merged

chore(ci): switch to Github Actions #3057

merged 4 commits into from
Jun 5, 2020

Conversation

imhoffd
Copy link
Contributor

@imhoffd imhoffd commented Jun 4, 2020

No description provided.

@imhoffd imhoffd requested a review from jcesarmobile June 4, 2020 19:29
@jcesarmobile
Copy link
Member

Cli test should run on macos since it adds iOS platform, so some things won’t be tested on Ubuntu.

Is it possible to specify a Xcode version? Or know which one was used? We only support Xcode 11+, but looks like they have a lot of versions, including Xcode 10.3

@imhoffd
Copy link
Contributor Author

imhoffd commented Jun 4, 2020

We can use xcode-select to use one of the installed versions. Looks like the default today is 14.4.1. I think it's fine to let CI use whatever is the default Xcode. We can also use a matrix strategy to test multiple versions of Xcode.

@jcesarmobile
Copy link
Member

I think one version is enough

@imhoffd imhoffd merged commit 8aefce0 into master Jun 5, 2020
@imhoffd imhoffd deleted the ci branch June 5, 2020 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants