Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios/Modals): Don't success until dismissed #2080

Merged
merged 1 commit into from
Oct 23, 2019
Merged

fix(ios/Modals): Don't success until dismissed #2080

merged 1 commit into from
Oct 23, 2019

Conversation

Justin-Credible
Copy link
Contributor

Resolves #2079

Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you have to remove the old success?

@jcesarmobile jcesarmobile changed the title Modal iOS: Don't call success callback immediately fix(ios/Modals): Don't success until dismissed Oct 23, 2019
Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@jcesarmobile jcesarmobile merged commit 64aa6c7 into ionic-team:master Oct 23, 2019
@Justin-Credible Justin-Credible deleted the fix/ios-modal-alert-defer-success-callback branch November 15, 2019 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Modals Plugin: alert on iOS should wait to execute callback until the modal is closed
2 participants