fix(android): handle input file with multiple accept mimetypes #1988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently when you add a file input with multiple mime-types in the accept attribute Capacitor will only use the first mimetype, this change make the file picker correctly use all specified mime-types.
jcesarmobile
approved these changes
Sep 24, 2019
jcesarmobile
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when you add a file input with multiple mime-types in the accept attribute Capacitor will only use the first mimetype, this change make the file picker correctly use all specified mime-types.
Example of input thats currently broken:
<input type="file" accept="image/jpeg,image/png,application/pdf">the example file input will only accept jpeg images instead of also accepting png and pdf's