Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add .gitignore to plugin template #1980

Closed
1 of 3 tasks
danielsogl opened this issue Sep 19, 2019 · 3 comments
Closed
1 of 3 tasks

feat: add .gitignore to plugin template #1980

danielsogl opened this issue Sep 19, 2019 · 3 comments

Comments

@danielsogl
Copy link
Contributor

Description of the problem:

Running the npx @capacitor/cli plugin:generate command will not generate a .gitignore but a .npmignore file that duplicates the files configuration inside the package.json file.
Also the command should init the plugin with git.

OS of the development machine

  • Windows
  • macOS
  • linux

Steps to reproduce:
run npx @capacitor/cli plugin:generate

@mburger81
Copy link

mburger81 commented May 15, 2020

Error still persists, does someone have a usefull template for .gitignore?

Okay, if we rename .npmignore into .gitignore from root bath it should be fine

@imhoffd imhoffd changed the title Generate new plugin: missing .gitignore feat: add .gitignore to plugin template Jun 9, 2020
@jcesarmobile
Copy link
Member

2.4.0 should generate the .gitignore file
was fixed in #3292

@ionitron-bot
Copy link

ionitron-bot bot commented Nov 11, 2022

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Capacitor, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Nov 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants